This repository has been archived by the owner on Sep 3, 2020. It is now read-only.
Implement a list method #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change implements a barebones list method to let users see what files exist on their drive (a nice complement to the pull function). Right now it just dumps a list of files and directories: If the path is a file then it is listed. If the path is a directory then the direct children are listed.
| } | ||
|
|
||
| var remoteChildren []*File | ||
| if remoteChildren, err = g.rem.FindByParentId(r.Id); err != nil { |
There was a problem hiding this comment.
We need to do pagination on FindByParentId. It returns only the top 100 children.
There was a problem hiding this comment.
Thanks for taking a look! I implemented that in #24. Are you saying there is some additional work?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements a barebones list method to let users see what files exist on their
drive (a nice complement to the pull function).
Right now it just dumps a list of files and directories:
If the path is a file then it is listed.
If the path is a directory then the direct children are listed.
Note this partially address issue #9.
Future work. Add options to list details about files in the cloud. Make it so users can tell files and directories apart.